Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-168400 | Updated pdf api clientId #648

Open
wants to merge 7 commits into
base: stage
Choose a base branch
from

Conversation

sharath-kannan
Copy link
Contributor

  • Updated the pdf viewer api's clientid to support hlx.(page|live) aem.(page|live)

Resolves: MWPW-168400

Test URLs:

PS: The pdfs in the above url can be viewed only after merging it to the main branch.

@sharath-kannan sharath-kannan requested a review from a team as a code owner February 24, 2025 07:44
Copy link

aem-code-sync bot commented Feb 24, 2025

Page Scores Audits Google
📱 /drafts/sharathkannan/12-ways-to-get-the-most-out-of-creative-cloud-for-teams?ma
rtech=off
Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /drafts/sharathkannan/12-ways-to-get-the-most-out-of-creative-cloud-for-teams?ma
rtech=off
Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@milo-pr-merge-cc
Copy link

Skipped merging 648: Feat(MWPW-168400): Updated pdf api clientId. due to failing checks

@aishwaryamathuria
Copy link
Collaborator

@sharath-kannan Could you look into the psi check failure

@spadmasa
Copy link
Collaborator

@spadmasa
Copy link
Collaborator

As per the confirmation provided validation can be done only after the pr gets merged to main

@milo-pr-merge-cc
Copy link

Skipped merging 648: Feat(MWPW-168400): Updated pdf api clientId. due to failing checks

@aishwaryamathuria aishwaryamathuria changed the title Feat(MWPW-168400): Updated pdf api clientId. MWPW-168400 | Updated pdf api clientId. Feb 25, 2025
@aishwaryamathuria aishwaryamathuria changed the title MWPW-168400 | Updated pdf api clientId. MWPW-168400 | Updated pdf api clientId Feb 25, 2025
@milo-pr-merge-cc
Copy link

Skipped merging 648: MWPW-168400 | Updated pdf api clientId due to failing checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants