Skip to content

Commit

Permalink
Merge pull request #78 from adobecom/triggernala
Browse files Browse the repository at this point in the history
fix login-accessing-public-page-with-non-member-user-logged-in-to-ado…
  • Loading branch information
cod17828 authored Feb 25, 2025
2 parents 54199b6 + 13748e4 commit 1f40003
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion nala/blocks/news/news.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export default {
tcid: '12',
name: '@login-news-page-non-member-of-spp-user',
path: '/solutionpartners/drafts/automation/regression/partner-news',
tags: '@dx-news @regression @anonymous',
tags: '@dx-news @regression',
baseURL: 'https://www.stage.adobe.com/partners.html',
data: {
partnerLevel: 'Platinum',
Expand Down
1 change: 1 addition & 0 deletions nala/blocks/signin/signin.page.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export default class SignInPage {
this.signInButtonStageAdobe = page.locator('.profile-comp.secondary-button');
this.profileIconButton = page.locator('.feds-profile-button');
this.joinNowButton = page.locator('a:has-text("Join now")');
this.gnavJoinNowButton = page.locator('.feds-cta-wrapper a:has-text("Join now")');
this.explorePastArticles = page.locator('a:has-text("Explore past articles")');
this.newsletterLink = page.locator('a:has-text("product newsletter")');
this.logoutButton = page.locator('[daa-ll="Sign Out"]');
Expand Down
2 changes: 1 addition & 1 deletion nala/blocks/signin/signin.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export default {
tags: '@dx-signin @regression @circleCi',
data: {
partnerLevel: 'tpp-platinum:',
expectedToSeeInURL: '/solutionpartners/error/contact-not-found',
expectedToSeeInURL: '/solutionpartners/drafts/automation/regression/public-page',
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion nala/blocks/signin/signin.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ test.describe('MAPP sign in flow', () => {
.toContain(`${features[6].data.expectedToSeeInURL}`);
const signInButton = await newTabPage.signInButton;
await expect(signInButton).toBeHidden();
const joinNowButton = await newTabPage.joinNowButton;
const joinNowButton = await newTabPage.gnavJoinNowButton;
await expect(joinNowButton).toBeVisible();
});
});
Expand Down

0 comments on commit 1f40003

Please sign in to comment.