Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodiak Fixes Round 2 #367

Merged
merged 11 commits into from
Feb 18, 2025
Merged

Kodiak Fixes Round 2 #367

merged 11 commits into from
Feb 18, 2025

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Feb 13, 2025

Describe your specific features or fixes and provide a preview link for the feature being incorporated

Resolves:

MWPW-166890
[Kodiak][R2]: Ssrf in [github.com/adobecom/ecc-milo]
MWPW-166697
[Kodiak][R2]: Ssrf in [github.com/adobecom/ecc-milo]
MWPW-163725
[Kodiak][R3]: DOMXSS in [github.com/adobecom/ecc-milo]
MWPW-161602
[Kodiak][R2]: Ssrf in [github.com/adobecom/ecc-milo]

Test URLs:

To test the feature, please load up the branch locally and run it against your local ESP and ESL server.
For more information on how to set up ESL and ESP locally, please refer to: FE Dev Wiki

Copy link

aem-code-sync bot commented Feb 13, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 13, 2025

Page Scores Audits Google
📱 /drafts/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.44%. Comparing base (13516fc) to head (70762c7).
Report is 418 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #367       +/-   ##
===========================================
- Coverage   67.22%   41.44%   -25.79%     
===========================================
  Files           2        2               
  Lines         238      374      +136     
===========================================
- Hits          160      155        -5     
- Misses         78      219      +141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiyundai qiyundai merged commit 57ba673 into dev Feb 18, 2025
4 checks passed
@qiyundai qiyundai deleted the kodiak-fixes-2 branch February 18, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants