Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business Hub - mWeb / Desktop - Marquee #210

Open
wants to merge 16 commits into
base: stage
Choose a base branch
from

Conversation

jsandland
Copy link
Collaborator

@jsandland jsandland commented Feb 24, 2025

Describe your specific features or fixes:

  • Remove dividing line at bottom of marquee on mobile
  • Logo above padding
  • Content Toggle padding
  • Ensure text wraps on smaller viewports
  • Header size on mWeb and Desktop
  • Content Toggle font-size on mWeb and Desktop

No Authoring Changes
Authoring Example: business-hub-marquee.docx

mWeb:
Resolves: MWPW-168284
Desktop:
Resolves: MWPW-168264

Test URLs:

Copy link

aem-code-sync bot commented Feb 24, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Feb 24, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 68.19%. Comparing base (0f0f90e) to head (d4f74de).
Report is 32 commits behind head on stage.

Files with missing lines Patch % Lines
...press/code/blocks/content-toggle/content-toggle.js 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #210      +/-   ##
==========================================
+ Coverage   67.45%   68.19%   +0.73%     
==========================================
  Files          60       62       +2     
  Lines        9984    10232     +248     
==========================================
+ Hits         6735     6978     +243     
- Misses       3249     3254       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:06 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:09 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:10 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:17 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:22 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:26 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:28 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 17:31 Inactive
@jsandland jsandland changed the title Business Hub - mWeb - Marquee Business Hub - mWeb / Desktop - Marquee Feb 24, 2025
Copy link
Collaborator

@JingleH JingleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why grid-marquee is also modified in this PR? I don't see the request of updating it in the ticket and it is affecting the h1 sizes of homepage as well...

@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 19:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to business-hub-marquee February 24, 2025 19:33 Inactive
@jsandland
Copy link
Collaborator Author

do we know why grid-marquee is also modified in this PR? I don't see the request of updating it in the ticket and it is affecting the h1 sizes of homepage as well...

I've replaced the grid-marquee with the headline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review Ready for peer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants