Skip to content

Commit

Permalink
Fix(mwpw-161843): favicon is loaded fast. (#3530)
Browse files Browse the repository at this point in the history
* Favicon quick load

* code optimization

* code optimization

* code optimization

* favicon is loaded post LCP
  • Loading branch information
sharath-kannan authored Feb 5, 2025
1 parent d8a37a7 commit 9de64bc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libs/utils/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -1176,6 +1176,8 @@ async function checkForPageMods() {
}

async function loadPostLCP(config) {
const { default: loadFavIcon } = await import('./favicon.js');
loadFavIcon(createTag, getConfig(), getMetadata);
await decoratePlaceholders(document.body.querySelector('header'), config);
const sk = document.querySelector('aem-sidekick, helix-sidekick');
if (sk) import('./sidekick-decorate.js').then((mod) => { mod.default(sk); });
Expand Down Expand Up @@ -1323,8 +1325,6 @@ async function documentPostSectionLoading(config) {
addRichResults(richResults, { createTag, getMetadata });
}
loadFooter();
const { default: loadFavIcon } = await import('./favicon.js');
loadFavIcon(createTag, getConfig(), getMetadata);
if (config.experiment?.selectedVariant?.scripts?.length) {
config.experiment.selectedVariant.scripts.forEach((script) => loadScript(script));
}
Expand Down

0 comments on commit 9de64bc

Please sign in to comment.