MWPW-152228: refactor georouting promises call (#3036)

* MWPW-152228: refactor georouting promises call * refactor long line
adobecom · Oct 29, 2024 · dfff83f · dfff83f
1 parent b916167
commit dfff83f
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/libs/features/georoutingv2/georoutingv2.js b/libs/features/georoutingv2/georoutingv2.js
@@ -251,14 +251,16 @@ async function showModal(details) {
   const { miloLibs, codeRoot } = config;
 
   const tabs = details.querySelector('.tabs');
+  const sectionMetaPath = `${miloLibs || codeRoot}/blocks/section-metadata/section-metadata.css`;
+  const georoutingPath = `${miloLibs || codeRoot}/features/georoutingv2/georoutingv2.css`;
   const promises = [
     tabs ? loadBlock(tabs) : null,
-    tabs ? loadStyle(`${miloLibs || codeRoot}/blocks/section-metadata/section-metadata.css`) : null,
-    new Promise((resolve) => { loadStyle(`${miloLibs || codeRoot}/features/georoutingv2/georoutingv2.css`, resolve); }),
+    tabs ? new Promise((resolve) => { loadStyle(sectionMetaPath, resolve); }) : null,
+    new Promise((resolve) => { loadStyle(georoutingPath, resolve); }),
+    import('../../blocks/modal/modal.js'),
   ];
-  await Promise.all(promises);
-  // eslint-disable-next-line import/no-cycle
-  const { getModal, sendAnalytics } = await import('../../blocks/modal/modal.js');
+  const result = await Promise.all(promises);
+  const { getModal, sendAnalytics } = result[3];
   sendAnalyticsFunc = sendAnalytics;
   return getModal(null, { class: 'locale-modal-v2', id: 'locale-modal-v2', content: details, closeEvent: 'closeModal' });
 }