MWPW-159032: Defaults to empty alt tag on the svg - Accessibility requirement

[joaquinrivero]

This exist before, and we are getting request by accessibility to added again for unity project

Defaults to empty alt tag on the image if no alt text is authored. Per accessibility best practices this declares the image as "decorative".

Resolves: MWPW-159032

Test URLs:

• https://mwpw-159032-svg--milo--joaquinrivero.hlx.page/
• Before: https://main--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?martech=off
• After: https://main--dc--adobecom.hlx.page/acrobat/online/test/sign-pdf-projectunity?martech=off&milolibs=MWPW-159032-svg--milo--joaquinrivero

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (ff054af) to head (086c1c8).
Report is 27 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3016      +/-   ##
==========================================
- Coverage   96.45%   96.44%   -0.01%     
==========================================
  Files         246      246              
  Lines       55909    55908       -1     
==========================================
- Hits        53925    53919       -6     
- Misses       1984     1989       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[github-actions]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

[overmyheadandbody]

Hi @joaquinrivero! Thanks for the contribution! This is quite important for accessibility. This comment's purpose is to:

1. Unmark this PR as stale :)
2. Ask that you please integrate @TsayAdobe's suggestion
3. Note that this is a great first step, but we'll likely need a few more changes to count this accessibility issue as solved. The codebase contains a bunch of inline SVGs that should get an alt tag as well. There are also other methods used to load SVGs, such as this one. Additional stories will likely be created and taken through the regular Master Backlog intake process.

[github-actions]

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

[overmyheadandbody]

If not done already, please rebase this with the stage branch, that should get some tests passing as well. It would also be helpful to add a test link that PSI can check to get the checks green. Thanks!

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/
🖥️	/

[tedAir]

Misunderstood the PR and the ticket relationship. For the issues this PR intends to solve, it is PASS.