Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-159605 Allow consumer apps set IMS timeout value #3037

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

TsayAdobe
Copy link
Contributor

  • After DC frictionless pages are switched to using the IMS guest token, we observed a small percentage of users may get an IMS timeout error. In the past we didn't log the error. The investigation is in MWPW-158350.
  • This change allows a consumer app to adjust the IMS timeout value. The DC team can fine tune the value to reduce the error rate.

Resolves: MWPW-159605

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Oct 14, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 14, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (1bdfd4a) to head (ebb16bf).
Report is 52 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3037      +/-   ##
==========================================
- Coverage   96.34%   96.33%   -0.01%     
==========================================
  Files         243      243              
  Lines       55284    55284              
==========================================
- Hits        53261    53260       -1     
- Misses       2023     2024       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could would love if you could contribute a more fine tuned value back, after your experimentation

Copy link
Contributor

@Blainegunn Blainegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TsayAdobe

@TsayAdobe TsayAdobe added the run-nala Run Nala Test Automation against PR label Oct 17, 2024
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 23, 2024

Skipped 3037: "MWPW-159605 Allow consumer apps set IMS timeout value" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

1 similar comment
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Oct 28, 2024

Skipped 3037: "MWPW-159605 Allow consumer apps set IMS timeout value" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 12dbfff into stage Oct 29, 2024
22 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-159605 branch October 29, 2024 08:14
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants