Added performance tab to the Preflight tool (#2773) #3056
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #3056 +/- ##
==========================================
+ Coverage 96.34% 96.35% +0.01%
==========================================
Files 243 246 +3
Lines 55284 56012 +728
==========================================
+ Hits 53261 53972 +711
- Misses 2023 2040 +17 ☔ View full report in Codecov by Sentry. |
added performance tab
mokimo
force-pushed
the
preflight-performance-tab
branch
from
b9d5250 to
55d3b95
Compare
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| } | ||
|
|
||
| export const checkFragments = () => conditionalItemUpdate({ | ||
| failsWhen: config.lcp.element.closest('.fragment') || config.lcp.element.closest('.section')?.querySelector('[data-path*="fragment"]'), |
There was a problem hiding this comment.
Is this taking deeper nested fragments into account?
There was a problem hiding this comment.
Yes, but just in the sense of, it tells you that there is a fragment being used: https://preflight-performance-tab--milo--mokimo.hlx.page/drafts/osahin/preflight-performance/marquee-deep-nested-fragments
... we could also surface nested fragments, e.g. "amount of fragments within fragments, 5" 🤔
Wdyt?
There was a problem hiding this comment.
I've heard of 4 levels deep nested fragments, so I think we should put this on the idea list, yes.
| // TODO MEP/Personalization | ||
| // TODO mobile / tablet? | ||
| // TODO create ticket for PSI API | ||
| // TODO link to documentation directly within the sections |
There was a problem hiding this comment.
todo, we could also check for commerce within the marquee
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-157715
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-157715
Description
A few todo's here and there but the features and flow should work and this should be ready for feedback and a first batch of testing.
Look & Feel
Resolves: MWPW-157715
Test instructions
Use the provided sample URLs, try to destroy the thing, close it, open it, open it on incognito, have pages with LCP, without, use production pages from bacom etc. to test this. I've encountered a lot of issues during development and I'm sure theres still many issues out there.
Test URLs: