Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-159595] - support same domain consumers in the links conversion feature #3067

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

robert-bogos
Copy link
Contributor

@robert-bogos robert-bogos commented Oct 21, 2024

@robert-bogos robert-bogos requested a review from a team October 21, 2024 08:48
@robert-bogos robert-bogos self-assigned this Oct 21, 2024
Copy link
Contributor

aem-code-sync bot commented Oct 21, 2024

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (543ef4d) to head (b62cc86).
Report is 23 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3067   +/-   ##
=======================================
  Coverage   96.43%   96.44%           
=======================================
  Files         245      245           
  Lines       55746    55755    +9     
=======================================
+ Hits        53757    53771   +14     
+ Misses       1989     1984    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robert-bogos robert-bogos requested a review from mokimo October 21, 2024 13:23
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@robert-bogos robert-bogos requested a review from a team October 22, 2024 08:25
@joaquinrivero joaquinrivero self-requested a review October 23, 2024 18:07
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Copy link

@NadiiaSokolova NadiiaSokolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-159595

@milo-pr-merge milo-pr-merge bot merged commit 34e21ad into adobecom:stage Oct 29, 2024
18 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants