Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3085

Merged
merged 14 commits into from
Oct 28, 2024
Merged

[Release] Stage to Main #3085

merged 14 commits into from
Oct 28, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Oct 23, 2024

Ruchika4 and others added 9 commits October 23, 2024 15:23
…cript (#3055)

* Update utils.js

* Add unit test

* Update utils.js

* incorporate review comments

* fix lint issue

* incorporate review comment
…hed (#3059)

added appending extra options to the iframe URL
…#2992)

* centre align "secure transactions" in footer

* change centre alignment for secure label instead of footer

---------

Co-authored-by: Rohit Sahu <[email protected]>
* added z-index 2 for merch sidenav

* updated mas deps
removed fork specific configuration
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900)

Revert "MWPW-156749: Fix video CLS  (#2849)"

This reverts commit d4134c8.

* MWPW-157946: added colon to be consistent with other sort options

* MWPW-157946: rearranged sort orders

* missed changing the way last modified was displayed

* missed changing the way last modified was displayed

* missed changing the way last modified was displayed

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <[email protected]>
Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Sheridan Sunier <[email protected]>
Co-authored-by: Sheridan Sunier <[email protected]>
* MWPW-153237: Test content for CCD validation

* review comments

* fix merge
opt-out class to prevent automatic addition of daa-ll
@milo-pr-merge milo-pr-merge bot requested review from a team and chrischrischris as code owners October 23, 2024 15:24
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Oct 23, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Copy link
Contributor

aem-code-sync bot commented Oct 23, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 23, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (c30fa5b) to head (c61c4d6).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files         245      245              
  Lines       55727    55746      +19     
==========================================
+ Hits        53740    53757      +17     
- Misses       1987     1989       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/543ef4d737f0ac4520a63eabfe772e5394c568c0/libs/features/spectrum-web-components/src/themes/light.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@milo-pr-merge milo-pr-merge bot merged commit 6314173 into main Oct 28, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.