Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a nala folder in the mep folder #3096

Closed
wants to merge 3 commits into from
Closed

adds a nala folder in the mep folder #3096

wants to merge 3 commits into from

Conversation

jpratt2
Copy link
Contributor

@jpratt2 jpratt2 commented Oct 28, 2024

This adds a nala folder and test script in the libs/mep folder so that we can run a mep test for "insertScript"

Applies to: MWPW-155037

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Oct 28, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 28, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (ff054af) to head (85e817a).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3096   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         246      246           
  Lines       55909    55909           
=======================================
  Hits        53925    53925           
  Misses       1984     1984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -0,0 +1,5 @@
// give a one-second delay to allow the DOM structure to exist

setTimeout(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prefer-arrow-callback> reported by reviewdog 🐶
Unexpected function expression.

Suggested change
setTimeout(function () {
setTimeout(() => {

@@ -0,0 +1,5 @@
// give a one-second delay to allow the DOM structure to exist

setTimeout(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <func-names> reported by reviewdog 🐶
Unexpected unnamed function.

// give a one-second delay to allow the DOM structure to exist

setTimeout(function () {
document.querySelector("body").style.color="orange";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.

Suggested change
document.querySelector("body").style.color="orange";
document.querySelector('body').style.color="orange";

// give a one-second delay to allow the DOM structure to exist

setTimeout(function () {
document.querySelector("body").style.color="orange";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '=' must be spaced.

Suggested change
document.querySelector("body").style.color="orange";
document.querySelector("body").style.color = "orange";

// give a one-second delay to allow the DOM structure to exist

setTimeout(function () {
document.querySelector("body").style.color="orange";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <quotes> reported by reviewdog 🐶
Strings must use singlequote.

Suggested change
document.querySelector("body").style.color="orange";
document.querySelector("body").style.color='orange';

@jpratt2 jpratt2 closed this Oct 28, 2024
@jpratt2
Copy link
Contributor Author

jpratt2 commented Oct 28, 2024

I will try again

@jpratt2 jpratt2 deleted the nala-folder branch October 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant