Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3628

Merged
merged 6 commits into from
Feb 6, 2025
Merged

[Release] Stage to Main #3628

merged 6 commits into from
Feb 6, 2025

Conversation

skholkhojaev and others added 5 commits February 5, 2025 16:01
…iewport Settings (#3532)

* removed movile testing in the keyboard and added it in a seperate file

* fixed linting

* fixed linting
* Favicon quick load

* code optimization

* code optimization

* code optimization

* favicon is loaded post LCP
* [MWPW-166631] applying style a11y changes to tabs

* [MWPW-161397] tab list height fix

* [MWPW-166631] dark tab shadow fix

* [MWPW-166631] reverting tab pill style

* [MWPW-166631] css code optimization

* [MWPW-166631] tab margin fix

* [MWPW-166631] reduces css repetitivnes
* MWPW-162345: Fix aside video on tablet

* MWPW-162345: Remove unnecessary aside from selector

Co-authored-by: Rares Munteanu <[email protected]>

---------

Co-authored-by: Rares Munteanu <[email protected]>
* updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error

* changed a ; to a ,
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Feb 5, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Feb 5, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 5, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@spadmasa
Copy link

spadmasa commented Feb 5, 2025

Hi @sharmrj , seeing the below issue in stage on arrows , can you please check if the pr caused this and revert #3625
https://www.stage.adobe.com/creativecloud/animation/discover.html
image

Copy link

@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gnav has broken experience. need to revert gnav console PR (or) fix the issue with new PR

…#3629)

Revert "Prevent a console error from the global navigation main menu (#3625)"

This reverts commit 91fb8d4.
@mokimo
Copy link
Contributor

mokimo commented Feb 5, 2025

@sigadamvenkata You can re-test.

@milo-pr-merge milo-pr-merge bot merged commit 98d34a8 into main Feb 6, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.