Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3640

Merged
merged 13 commits into from
Feb 11, 2025
Merged

[Release] Stage to Main #3640

merged 13 commits into from
Feb 11, 2025

Conversation

sonawanesnehal3 and others added 6 commits February 6, 2025 17:50
* Unav upgrade 1.4

* Adding scopes for ProfileSwitching

* Enabling new mobile tray experience

* Updated for unav reload for mobile tray

* Fixing profile switching

* Adding unit tests

* Adding UT

* IDACTMGT-17106 and addressing review comments

* Adding fix for MWPW-166074

* Adding additional checks

* Adding additional checks

---------

Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Snehal Sonawane <[email protected]>
* Datastream Bug

* Datastream Bug

---------

Co-authored-by: Akansha Arora <>
* fix for modal video not showing

* fix for vimeo video not showing in modal
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Feb 6, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Feb 6, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 6, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

console.log(err);

* overriding descr elements for accordion

* hotfix

* fixed unit tests

* fixed nala tests

* fixed editorial-accordion unit tests
* MWPW-165806 Visual heading text reading fix

* add aria level
…le (#3631)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <[email protected]>

* MWPW-163904: saving work

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <[email protected]>
Co-authored-by: Raghav Sharma <[email protected]>
Co-authored-by: Sheridan Sunier <[email protected]>
…n MEP commands (#3623)

* first commit

* add unit test
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner February 7, 2025 01:08
@robert-bogos
Copy link
Contributor

Hi @sigadamvenkata !
Are we on track with the E2E testing for the Unav changes? There is a high-priority change in this batch and we need it live today, 11 Feb, 7 am PT

Copy link

@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are completed Unav 1.4 validation on STAGE and Good to go

@milo-pr-merge milo-pr-merge bot merged commit ba3e6aa into main Feb 11, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.