MWPW-158500: Universal promo terms link #3647
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/commerce.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/mas.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-card.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-icon.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-mnemonic-list.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-offer-select.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-sidenav.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-stock.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-twp-d2p.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/dist/mas.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/src/commerce.js
Outdated
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @st-angelo-adobe ,
while i am checking the changes, could you add Nala test for this feature pls?
for CCD, we have this gallery page: https://main--milo--adobecom.hlx.live/libs/features/mas/docs/ccd.html
these cards we use in tests, let's just add a new card somewhere here
You can use this card:
https://mwpw-158500--mas--adobecom.aem.live/studio.html?milolibs=mwpw-158500--milo--adobecom#path=nala&query=018bf7f7-1e82-4b16-9dd1-039ee013e490
then you can add a test to https://github.com/adobecom/milo/blob/stage/nala/features/mas/ccd/masccd.test.js
this is instruction how to run nala locally
https://github.com/adobecom/milo/blob/stage/README.md#nala-e2e-ui-testing
after installing deps you just need to run 'aem up' in one tab and 'npm run nala local test=masccd.test.js' in another and you'll have them triggered locally
|
@st-angelo-adobe Hi, Have done with regressions on milo... also need to check with you on studio authoring : cc @3ch023 |
|
Hey @Roycethan. The OSI field is basically not populated on the fragment. Unfortunately you can't do it in the UI, there another PR for this, not sure if it works still, 'cause it's in development. |
Pregrags branch worked for me, so we can try to use it for combined testing, yes |
|
@st-angelo-adobe Verified ( started thread on authoring with Nick in the ticket https://jira.corp.adobe.com/browse/MWPW-158500) and marked label for now to proceed - Plz update latest from stage and also fix PSI checks cc @3ch023 |
|
thx @Roycethan , @st-angelo-adobe fixed checks so I am setting Ready for Stage |
Resolves: MWPW-158500
Test URLs:
Before: https://main--milo--adobecom.hlx.live/docs/library/kitchen-sink/merch-card?martech=off
After: https://mwpw-158500--milo--adobecom.hlx.live/docs/library/kitchen-sink/merch-card?martech=off
CCD Gallery:
mwpw-158500--milo--adobecom.aem.page/libs/features/mas/docs/ccd.html?martech=off