MWPW-160954 Marketo Multi-step #3671
Conversation
Brandon32
added
run-nala
Brandon32
requested review from
JasonHowellSlavin,
meganthecoder,
mokimo and
rlesliej
Brandon32
changed the title
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
libs/blocks/marketo/marketo-multi.js
Outdated
| formEl.querySelectorAll('.mktoFormRowTop').forEach((row) => { | ||
| const rowAttr = row.getAttribute('data-mktofield') || row.getAttribute('data-mkto_vis_src'); | ||
| const step = VALIDATION_STEP[rowAttr] ? Math.min(VALIDATION_STEP[rowAttr], totalSteps) : 1; | ||
| row.setAttribute('data-validate', step); | ||
| }); |
There was a problem hiding this comment.
Super nit, but pulling this out into a named function may add some readability.
libs/blocks/marketo/marketo-multi.js
Outdated
| const VALIDATION_STEP = { | ||
| name: '2', | ||
| phone: '2', | ||
| mktoFormsJobTitle: '2', | ||
| mktoFormsFunctionalArea: '2', | ||
| company: '3', | ||
| state: '3', | ||
| postcode: '3', | ||
| mktoFormsPrimaryProductInterest: '3', | ||
| }; |
There was a problem hiding this comment.
Will we eventually want this configuration to be set up elsewhere or by authors?
There was a problem hiding this comment.
There are multiple directions on how this would be configured, but right now this feature is more of a test.
We're not sure what the authoring would look like and it may by configured by the template definitions.
Brandon32
force-pushed
the
bmarshal/multi-step
branch
from
4459de0 to
39a5d7c
Compare
|
Reminder to set the |
Brandon32
force-pushed
the
bmarshal/multi-step
branch
2 times, most recently
from
72a9406 to
2e78390
Compare
Brandon32
force-pushed
the
bmarshal/multi-step
branch
from
2e78390 to
df6b5b1
Compare
Resolves: MWPW-160954
Test URLs:
BACOM URLs: