MWPW-168109: do not modify absolute path to a script hosted in DAM when using insertScript action #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en using insertScript action
|
vgoodric
reviewed
Feb 19, 2025
Co-authored-by: Vivian A Goodrich <[email protected]>
vgoodric
approved these changes
Feb 19, 2025
markpadbe
approved these changes
Feb 19, 2025
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
* MWPW-168109: do not modify absolute path to a script hosted in DAM when using insertScript action (#3708) * MWPW-168109: do not modify absolute path to a script hosted in DAM when using insertScript action * wording change * Update libs/features/personalization/personalization.js Co-authored-by: Vivian A Goodrich <[email protected]> --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> * [MWPW-166126] Add new "updateAttribute" action to MEP (#3670) * Get last string, check for match, save as attribute. * Attribute update, working state. * Refactor, good state. * Parameter update refactor. * Unit testing. * Highlight updates. * Unit test update. * Code review updates. * Error log update. * Spacing fix. * PR update. * Update libs/features/personalization/personalization.js * unit test update --------- Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Dave Linhart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-168109
Test URLs:
QA links :
Before: https://main--cc--adobecom.hlx.page/cc-shared/fragments/tests/2025/q1/insert-script-absolute-path/marquee
After: https://main--cc--adobecom.hlx.page/cc-shared/fragments/tests/2025/q1/insert-script-absolute-path/marquee?milolibs=insert-script-abs-path ( you should see a h1 tag at the bottom of the page saying
I am an appended header via an external script!and the network tab should show that test.js came from acom not the preview domain)