Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166176 - Stop initial tabs click propagation #3726

Open
wants to merge 2 commits into
base: stage
Choose a base branch
from

Conversation

rgclayton
Copy link
Contributor

  • Stops tabs block initial click event from bubbling up.
  • There should be no impact to the tabs block functionality or visually.

Context:
After signing in (IMS sign in) if the tabs block is on a page and a user quickly navigates to the sign in to switch profiles, the signed in dropdown menu is closed due to tabs block loading latter on the page and firing a click event to inititalize.

Resolves: MWPW-166176

Test URLs:

CC Stage URLs

BACOM URLs

Testing notes:

  • Use browser dev tools to throttle network to 4G slow
  • Load example page. If not signed into IMS sign in and reload page (Might need to be on VPN too).
  • Load page and click on your signed in icon to display the drop down menu.
  • Wait a few seconds. The menu should not auto close. It will with the before link.
  • Tabs block needs to be on the tested page.

Copy link
Contributor

aem-code-sync bot commented Feb 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 21, 2025

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@rgclayton
Copy link
Contributor Author

Nala tests are not failing for tabs on local.

Looks like errors with promo code and m@s...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants