Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-167759] Hero marquee bg-bottom-tablet fix #3735

Open
wants to merge 1 commit into
base: stage
Choose a base branch
from

Conversation

overmyheadandbody
Copy link
Contributor

This ensures that the background image of a Hero Marquee is glued to the bottom of the block on tablet devices when the bg-bottom-tablet variant is applied. There were a few ways to achieve this, but ultimately I decided to follow the strategy already used for mobile on L291.

The file had quite a lot of extra space characters which got removed, the only code difference is on L325.

Before After
Screenshot 2025-02-25 at 15 56 05 Screenshot 2025-02-25 at 15 55 58

Resolves: MWPW-167759

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Feb 25, 2025

Page Scores Audits Google
📱 /drafts/klee/test-hero?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/klee/test-hero?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants