Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWPW-140873] Refactor automation test scripts #233

Merged
merged 7 commits into from
Jan 3, 2024
Merged

[MWPW-140873] Refactor automation test scripts #233

merged 7 commits into from
Jan 3, 2024

Conversation

skumar09
Copy link
Contributor

@skumar09 skumar09 commented Dec 15, 2023 •
edited
Loading

MWPW-140873: Refactor automation test scripts

PR includes

  • Refactor Automation test scripts for the following blocks/features
    • Column
    • HowTo
    • Quote
    • Zpattern
    • HtmlExtn (feature)

@skumar09 skumar09 added the run-nala Run Nala Test Automation against PR/Branch label Dec 15, 2023
amauch-adobe
amauch-adobe approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, was there a ticket or description for the refactor provided I didn't see anything in the PR description. Just wanted to make sure I was looking at the PR correctly. For what I know it looks awesome!

@skumar09 skumar09 added do not merge PR should not be merged yet and removed do not merge PR should not be merged yet labels Dec 15, 2023
chadsunvice
chadsunvice approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@chadsunvice chadsunvice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skumar09 skumar09 changed the title [Quote Block] Refactor and Update quote block [MWPW-140873] Refactor automation test scripts Jan 3, 2024
@skumar09 skumar09 merged commit 1e257a7 into adobecom:main Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amauch-adobe amauch-adobe amauch-adobe approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@chadsunvice chadsunvice chadsunvice approved these changes

Assignees
No one assigned
Labels
run-nala Run Nala Test Automation against PR/Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skumar09 @amauch-adobe @JackySun9 @chadsunvice @nateekar