Helpx_Milo Components Script Fixes #235
Conversation
configs/helpx.config.js
Outdated
| @@ -35,11 +34,11 @@ const config = { | |||
| workers: process.env.CI ? 2 : undefined, | |||
| /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | |||
| reporter: process.env.CI | |||
| ? [['github'], ['list'], ['../utils/reporters/base-reporter.js']] | |||
There was a problem hiding this comment.
You need to add base-reporter.js
There was a problem hiding this comment.
@JackySun9 I appreciate your comments. Added Base Reporter along with d5eb7a1.
| @@ -4,8 +4,26 @@ module.exports = { | |||
| { | |||
| tcid: '0', | |||
| name: '@draft', | |||
| path: '/automation/blocks/Drafts/draft-test', | |||
| path: '/automation/blocks/Draft/draft-test.html', | |||
There was a problem hiding this comment.
Yes, Recently I made some folder changes.
|
@kirupacommit : Helpx daily run is failing because of the test title
Your test title does not have name and tag information.
Please refer to the Nala test template
The
|
configs/helpx.config.js
Outdated
| @@ -35,11 +34,11 @@ const config = { | |||
| workers: process.env.CI ? 2 : undefined, | |||
| /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | |||
| reporter: process.env.CI | |||
| ? [['github'], ['list'], ['../utils/reporters/base-reporter.js']] | |||
There was a problem hiding this comment.
@kirupacommit :
Any reason not using base-reporter.js , we need this for dailyrun report metrics
There was a problem hiding this comment.
Now i have added Base reporter to the helpx Project
configs/helpx.config.js
Outdated
| @@ -77,4 +80,4 @@ const config = { | |||
| }, | |||
| ], | |||
| }; | |||
| export default config; | |||
| export default helpxconfig; | |||
There was a problem hiding this comment.
@kirupacommit : Any reason for changing this from default config?, as other dependent libraries, use default config
There was a problem hiding this comment.
Thought of giving project specific config name so used helpxconfig, since other libs are using config i have changed to default config.
|
@skumar09 Thanks for your insight on the Github Actions , Now i have renamed the test cases and triggered the jobs as well. Thank You! |
|
tests/helpx/codeBlock.test.js
Outdated
| baseURL, | ||
| }) => { | ||
| console.info(`[Test Page]: ${baseURL}${features[0].path}`); | ||
| test(`verify Code Block Page Elements`, async ({baseURL}) => { |
There was a problem hiding this comment.
Please update the test title as per the Nala test title template.
| this.thirdStepLink = page.locator("//div[contains(@daa-lh,'b11|procedure|nopzn|nopzn')]/ol/li[3]/div/strong/a[contains(@href,'https://account.adobe.com/plans')]"); | ||
| this.iconinprocedureComponet = page.locator("//div[contains(@daa-lh,'b11|procedure|nopzn|nopzn')]/ol/li[6]/div/ol/li/span[contains(@class,'icon icon-objectives margin-left margin-right')]"); | ||
| this.notealertinprocedure = page.locator("//div[contains(@daa-lh,'b11|procedure|nopzn|nopzn')]/ol/li[6]/child::div/child::div[contains(@class,'note alert')]"); | ||
| this.noteiconinprocedure = page.locator("//div[contains(@daa-lh,'b11|procedure|nopzn|nopzn')]/ol/li[6]/child::div/child::div[contains(@class,'note alert')]/span[contains(@class,'note-icon')]"); |
There was a problem hiding this comment.
- I would not suggest using such a lengthy locator ( i.e., Xpath)
- Playwright provides plenty of other better options; please try using better selectors like CSS ( please refer to playwright locators
daa-lh,'b11|procedure|nopzn|nopznare personalization attributes
No description provided.