Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabing milo tests on bacom #301

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Enabing milo tests on bacom #301

merged 1 commit into from
Mar 28, 2024

Conversation

Dli3
Copy link
Contributor

@Dli3 Dli3 commented Mar 28, 2024

MWPW-145790
Enabing milo tests on bacom.

@Dli3 Dli3 added the run-nala Run Nala Test Automation against PR/Branch label Mar 28, 2024
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Although, I think it would be good to look at the sustainability of this approach since you will need to keep updating your sharepoint directory with any changes made for milo core tests to ensure they are in sync with one another. I'm guessing this ticket was derived from the desire to make sure any BAcom code changes didn't affect Milo core blocks prior to it going to staging and being merged into Milo (basically proactively ensuring code changes don't break Milo core libs/blocks). It might be prudent to discuss these needs in the next Nala Sync meeting since other teams may want to do this and might require a more sustainable approach.

cc @JackySun9 and @skumar09 can chime in.

@Dli3
Copy link
Contributor Author

Dli3 commented Mar 28, 2024

Approved. Although, I think it would be good to look at the sustainability of this approach since you will need to keep updating your sharepoint directory with any changes made for milo core tests to ensure they are in sync with one another. I'm guessing this ticket was derived from the desire to make sure any BAcom code changes didn't affect Milo core blocks prior to it going to staging and being merged into Milo (basically proactively ensuring code changes don't break Milo core libs/blocks). It might be prudent to discuss these needs in the next Nala Sync meeting since other teams may want to do this and might require a more sustainable approach.

cc @JackySun9 and @skumar09 can chime in.

This is to help bacom SOT with stage to main verification. But I agree that there will be a bit of maintenance work with updating the sharepoint files.

We can discuss in the sync meeting.
cc @JackySun9 @skumar09

@Dli3 Dli3 merged commit dd86eb2 into main Mar 28, 2024
7 checks passed
@Dli3 Dli3 deleted the runOnBacom branch March 28, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-nala Run Nala Test Automation against PR/Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants