Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for headers and redirects #447

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Adding tests for headers and redirects #447

merged 2 commits into from
Oct 8, 2024

Conversation

Dli3
Copy link
Contributor

@Dli3 Dli3 commented Oct 8, 2024

MWPW-159844
Adding tests for:

  • Checking pages are returning the correct x-adobe-content response header
  • Checking that urls without a trailing slash are redirecting and returns a 200

@Dli3 Dli3 added the run-nala Run Nala Test Automation against PR/Branch label Oct 8, 2024
meganthecoder
meganthecoder approved these changes Oct 8, 2024
View reviewed changes
Copy link

@meganthecoder meganthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small comment

@Dli3 Dli3 force-pushed the headers-redirects branch from 17714c0 to 58b5b64 Compare October 8, 2024 18:36
@Dli3 Dli3 merged commit ad03112 into main Oct 8, 2024
4 checks passed
@Dli3 Dli3 deleted the headers-redirects branch October 8, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganthecoder meganthecoder meganthecoder approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Brandon32 Brandon32 Awaiting requested review from Brandon32

@afmicka afmicka Awaiting requested review from afmicka

@JasonHowellSlavin JasonHowellSlavin Awaiting requested review from JasonHowellSlavin

@skumar09 skumar09 Awaiting requested review from skumar09

Assignees
No one assigned
Labels
run-nala Run Nala Test Automation against PR/Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dli3 @meganthecoder @JackySun9