update screenshot tests to public s3 #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JackySun9
commented
Nov 14, 2024
JackySun9
commented
- update screenshot tests to public s3
- add git action to run them
amauch-adobe
approved these changes
Nov 14, 2024
.github/workflows/run-screendiff.yml
Outdated
| - platform: windows-latest | ||
| categories: ["sot","milo","feds","caas","uar","uar-ai"] | ||
| - platform: macos-latest | ||
| categories: ["dc","bacom","graybox-bacom","graybox-dc"] |
There was a problem hiding this comment.
This is just a question, not necessarily an issue. Is there a reason for why categories only run on a certain platform and not both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.