-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ember 5 and convert to a v2 addon #470
Merged
mansona
merged 17 commits into
adopted-ember-addons:master
from
wozny1989:bump-to-Ember-4-x
May 15, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
572c2d2
chore: upgrade to Ember 4
wozny1989 7fe91b3
fix: using 'content' or defined custom params few times in the same c…
wozny1989 9b6956b
fix: error after change route
wozny1989 eb4b194
chore: update node version on CI
wozny1989 ef229ad
chore: update according to Ember blueprints ~4.4.0
wozny1989 ffe8bfd
bump node version
wozny1989 7365e4f
delete redundant .eslintrc.js file
wozny1989 bf0a9d7
bump @embroider/test-setup
wozny1989 1bb3c08
make embroider tests happy
wozny1989 406b09a
migrate yarn to npm
wozny1989 de50fa1
migrate to addon v2
wozny1989 3818027
Merge pull request #2 from wozny1989/migration-to-addon-v2
wozny1989 e2a21c2
migrate to pnpm
wozny1989 2ab09ba
Merge pull request #4 from wozny1989/migrate-to-pnpm
wozny1989 d9629f4
v4.12.3...v5.8.1
wozny1989 742f2e3
Merge pull request #3 from wozny1989/bump-to-ember-5
wozny1989 f09d503
add scenarios for ember 4.12 and 5.8
wozny1989 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,2 @@ | ||
# See https://help.github.com/ignore-files/ for more about ignoring files. | ||
|
||
# compiled output | ||
/dist/ | ||
/tmp/ | ||
|
||
# dependencies | ||
/bower_components/ | ||
/node_modules/ | ||
|
||
# misc | ||
/.env* | ||
/.pnp* | ||
/.sass-cache | ||
/connect.lock | ||
/coverage/ | ||
/libpeerconnection.log | ||
/npm-debug.log* | ||
/testem.log | ||
/yarn-error.log | ||
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/bower.json.ember-try | ||
/package.json.ember-try | ||
node_modules | ||
.DS_Store |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that 5.8 was just released and it's current state is
LTS candidate
, until 5.9 get released.Ember released 5.8
IMHO it should be ok to add the next LTS version in advance.