Fix tests for empty strings in _setup #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a macro like OLD_JAVA_HOME expands to nothing, the resulting command (if [ ]; then ...) is considered syntactically invalid by some versions of bash. This avoids that problem by letting make evaluate the test by using $(if). Signed-off-by: Keith W. Campbell <[email protected]>
karianna
approved these changes
Feb 1, 2025
smlambert
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a macro like
OLD_JAVA_HOMEexpands to nothing, the resulting command (if [ ]; then...) is considered syntactically invalid by some versions of bash. This avoids that problem by letting make evaluate the test by using$(if).See sample failure in https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.functional_x86-32_windows_Personal_testList_0/236/console