-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to release notes is not prominent on the releases page #2128
Link to release notes is not prominent on the releases page #2128
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2128 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 85 85
Lines 6270 6274 +4
Branches 535 534 -1
=======================================
+ Hits 6218 6222 +4
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: George Adams <[email protected]>
<Link to={`/temurin/release-notes?version=${source.release_name}`} style={{paddingRight: '20px'}}><MdNotes /><Trans>See Release Notes</Trans></Link> | ||
<Link to="/installation/"><IoMdHelpBuoy /><Trans>Read how to install Eclipse Temurin</Trans></Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this work with shorter text, e.g. "Release Notes", "Installation Guide", "Source Code"
The source code link is currently below the binaries table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test your proposal and let you know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of change
This PR is submitted to fix the point N°1 of the issue #1508
1 - Link to release notes is not prominent on the releases page. The notes should be easily found.
@tellison suggested this good idea: The "release notes" looks a bit lonely on that wide screen too, so maybe we could include a link to the installation pages alongside it too (or something equally relevant).
Checklist
npm test
passes