Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adoptium.net-1508] Release notes: filters contains only available values #2184

Conversation

xavierfacq
Copy link
Member

Description of change

This PR is to fix the point 12 of the issue #1508

In the header of the table, Release notes can be filtered.
With this modifications, only available values for priority / type / component fileds are displayed.

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 5ac8bfa
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64f8156957093d0008912275
😎 Deploy Preview https://deploy-preview-2184--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2184 (5ac8bfa) into main (b5e327d) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2184   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          87       87           
  Lines        6440     6464   +24     
  Branches      544      550    +6     
=======================================
+ Hits         6388     6412   +24     
  Misses         52       52           
Files Changed Coverage Δ
src/components/ReleaseNotesRender/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review September 5, 2023 16:36
@xavierfacq xavierfacq changed the title [adoptium.net-1508] Release notes: filters contains only available va… [adoptium.net-1508] Release notes: filters contains only available values Sep 5, 2023
@gdams
Copy link
Member

gdams commented Sep 5, 2023

Looks like we're getting duplicate values in the dropdowns

Screenshot 2023-09-05 at 22 15 37

@xavierfacq
Copy link
Member Author

Looks like we're getting duplicate values in the dropdowns

Screenshot 2023-09-05 at 22 15 37

You are right, there was a problem when navigate from a version and back to another.

It's now fixed, by cleaning the previous values.

@gdams gdams merged commit 2829cf7 into adoptium:main Sep 6, 2023
@xavierfacq xavierfacq deleted the feature/release_notes_filter_on_available_values branch September 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants