-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagbuilds #914
Tagbuilds #914
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
@karianna yes, agree, better to delete the lines |
Signed-off-by: Andrew Leonard <[email protected]>
run tests |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comment before I properly analyse the code - can we add some end-user information on this new process into https://github.com/adoptium/ci-jenkins-pipelines/blob/master/README.md where we describe the current nightly triggering.
In this case I'd actually prefer to have them present and commented out so it's obvious where the time-based scheduling can be re-enabled if desired. We will presumably still need this functionality for new releases while they are maintained by Oracle and not getting regular tags. I guess as a middle ground we could just leave it in the JDK22+ ones if you don't want to retain it for all of them. |
Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic SGTM subject to my limited groovy expertise ... Most of the things in here are queries and doc suggestions that it would be nice to have answers to prior to giving a formal approval but it looks like you've done some testing on it so it should be good. We'll see if there are any other edge cases we've missed once it goes live, but this should be a lot nicer than my original prototype code that we've been relying on for a few months!
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
thanks for pointing out, yes updated
thanks for pointing out, updated and added description of pipeline groovy and parameters |
Yes, i've added back in as a comment for jdk22.groovy, which will be used as a basis for jdk22u.groovy which will required the schedule |
Signed-off-by: Andrew Leonard <[email protected]>
Raised question in slack about whether there might be a better name than |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. A couple of further comments but I'm happy for this to go in once you'r happy with the testing :-)
@@ -151,6 +151,12 @@ disableJob = true | |||
|
|||
#### triggerSchedule_nightly / triggerSchedule_weekly / triggerSchedule_evaluation / triggerSchedule_weekly_evaluation | |||
|
|||
All JDK versions now support "beta" EA triggered builds from the publication of upstream build tags. Eclipse Adoptium no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just realised because of the way that this is formatted on the screen that 'EA' is just above "Eclipse Adoptium" so here's a clarification - minor risk of confusion but better to avoid it ;-)
All JDK versions now support "beta" EA triggered builds from the publication of upstream build tags. Eclipse Adoptium no | |
All JDK versions now support "beta" earle-access (EA) triggered builds from the publication of upstream build tags. Eclipse Adoptium no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a typo so I didn't commit that.
Provides tag driven builds for all jdk versions, main & evaluation
Features:
Test job: https://ci.adoptium.net/job/build-scripts/job/utils/job/betaTrigger_8ea/18/parameters/
Fixes: #902