-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta Zip Loading #180
base: master
Are you sure you want to change the base?
Beta Zip Loading #180
Conversation
Manifest can now load zip files. AssetPackLoader saves each file in the zip as a blob and loads normally. - only tested so far with png, jpeg, mp3, ogg, fnt, and xml so far - only works if blob is supported
Cool, will this work on a Flash target too? |
Nope, but that's an easy change! I'll commit one with Flash support tomorrow. |
Added flash support. FlashAssetPackLoader loads the zip file using a URLLoader. Each file in the zip is loaded in the same way as a regular file except it uses bytes instead of a URLRequest - tested with png, jpg, mp3, xml, and fnt
Added tar loading to flash and html5. Works similar to zip loading except it uses format.tar.Reader - note: I'm not sure why loading a tar entry in HtmlAssetPackLoader doesn't work as an inline function
@aduros Any thoughts on whether this should be merged in or not? |
This is a little under-tested. I'd call it "Beta" quality level. It works in our limited tests, but we never pushed it to 100% because for our target devices it didn't wind up improving load times (unpacking took longer than downloading). It's an open question if that's preferable to having no ZIP/TAR support. |
Yeah, Keith and I talked about this offline when he was working on it. Since it didn't show a improvement, I'd rather avoid the maintenance cost of merging it. It's possible that it could be optimized and retested later, but I don't think anyone's looking at it for now. |
Manifest can now load zip files. AssetPackLoader saves each file in
the zip as a blob and loads normally.