Skip to content

Reimplement split and flatten in Data.List.NonEmpty #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2022
Merged

Reimplement split and flatten in Data.List.NonEmpty #1723

merged 3 commits into from
Mar 8, 2022

Conversation

MatthewDaggitt
Copy link
Contributor

Reasons for this change:

  1. Should live in Data.List.NonEmpty.Base but because they mixed computation and proofs they could not.
  2. The names weren't very descriptive of what they did. N.B. I'm open to shortening them to groupSeqs and ungroupSeqs if people would prefer.
  3. They were blocking the deprecation of the inspect idiom in Attempt at deprecating inspect idiom #1630

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Feb 26, 2022
@MatthewDaggitt MatthewDaggitt merged commit a9e97a3 into master Mar 8, 2022
@MatthewDaggitt MatthewDaggitt deleted the nonempty-ops-refactor branch March 8, 2022 09:32
@andreasabel andreasabel mentioned this pull request Jul 24, 2023
Merged
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
Merged
@andreasabel andreasabel mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallais gallais gallais left review comments

Assignees
No one assigned
Labels
breaking library-design naming refactoring
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewDaggitt @gallais