Agda PR #7322 compatibility #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Eliminate many propositional equality imports * Fix merge conflict in Data.Bool.Properties Co-authored-by: G. Allais <[email protected]> --------- Co-authored-by: G. Allais <[email protected]>
To fix agda/agda#6654, we've decided that large indices will no longer be allowed by default. There is an infective flag `--large-indices` to bring them back, but none of the uses of large indices in the standard library were essential: to avoid complicated mutually-recursive PRs across repos, I adjusted the levels to check with `--no-large-indices` instead of adding the flag to the modules that used them.
* Simplify some `Relation.Binary` imports * Format * Better naming scheme * Fix tests * Merge issues
* Simplify leftover `Function` imports * `Function` -> `Function.Base` Co-authored-by: G. Allais <[email protected]> --------- Co-authored-by: G. Allais <[email protected]>
* Simplify more `Data.Product` import to `Data.Product.Base` * Missed an import
…#2019) * Simplify import of `Data.List.Relation.Binary.Pointwise` in agda-stdl * rectifications on Data.List.Relation.Binary.Pointwise import * rectifications on Data.List.Relation.Binary.Pointwise import * Delete weights-README.dot * Delete weight.png * Delete README.dot
* Simplify more `Data.Product` import to `Data.Product.Base` * Simplify more `Data.Product` import to `Data.Product.Base` * Indent
* Update LICENSE year * Remove extraneous 'i' --------- Co-authored-by: Lex van der Stoep <[email protected]>
* additional proofs and patterns in `Data.Nat.Properties` * added two projections; refactored `pad*` operations * `CHANGELOG` * removed one more use * removed final uses of `<″-offset` outside `Data.Nat.Base|Properties` * rename `≤-proof` to `m≤n⇒∃[o]m+o≡n` * removed new pattern synonyms * interim commit: deprecate everything! * add guarded monus; make arguments more irrelevant * fixed up `CHANGELOG` * propagate use of irrelevance * tidy up deprecations; reinstate `s<″s⁻¹` for `Data.Fin.Properties` * tightened up the deprecation story * paragraph on use of `pattern` synonyms * removed `import` * Update CHANGELOG.md Fix refs to Algebra.Definitions.RawMagma * Update Base.agda Fix refs. to Algebra.Definitions.RawMagma * inlined guarded monus definition in property * remove comment about guarded monus
* Make the main home of `decToMaybe` be `Relation.Nullary.Decidable.Core`, but deprecate the one in `Data.Maybe.Base` instead of removing it entirely. Fix the library accordingly. Note that this forces `Relation.Nullary.Decidable.Core` to use `Agda.Builtin.Maybe` to avoid a cyclic import. This can be fixed once the deprecation is done. * Update src/Relation/Nullary/Decidable/Core.agda Good idea. Co-authored-by: G. Allais <[email protected]> * simplified the deprecation * `CHANGELOG` * narrowed import too far * tweak a couple of the solvers for consistency, as per suggestions. * chnage to `public` re-export of `Relation.Nullary.Decidable.Core.decToMaybe` * Revert "chnage to `public` re-export of `Relation.Nullary.Decidable.Core.decToMaybe`" This reverts commit 256a505. * `fix-whitespace` * simplify `import`s * make consistent with `Idempotent` case * tidy up * instead of an alias, open public so that Agda knows these really are the same. This is a better deprecation strategy. * rename(provisional)+deprecate * knock-on * knock-on: refactor via `dec⇒maybe` * deprecation via delegation * fix `CHANGELOG` --------- Co-authored-by: G. Allais <[email protected]> Co-authored-by: James McKinna <[email protected]> Co-authored-by: jamesmckinna <[email protected]>
* Tidy up CHANGELOG in preparation for v2.1 release candidate * Fixed WHITESPACE * Fixed James' feedback and improved alphabetical order
* fixes #2400: use explicit quantification * fix knock-ons
|
Suggest pausing this until after the v2.1 release? |
|
couple fixes for changelog rendering
andreasabel
force-pushed
the
issue7322-compat
branch
from
52e361d to
0c692ce
Compare
andreasabel
force-pushed
the
issue7322-compat
branch
from
0c692ce to
8dd618a
Compare
|
I updated the Agda commit hash for the experimental branch in the CI so that it builds the latest Agda (needed for this PR). |
|
I made a new label "Agda compatibility" for these kinds of additions. Std-lib tsars, feel free to modify this label to your liking. Merging this now so Agda can be restored to tracking |
MatthewDaggitt
added
upstream
I've been using the |
|
Happy for a coarse-grained labelling philosophy, but I might prefer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the necessary changes for the experimental branch to be compatible with agda/agda#7322 once it is merged.
The reason for the large number of commits here is that I decided to also bring
experimentalup to date with the current master, since it seems to be lagging behind at the moment.