[ refactor ] Algebra.Properties.Semiring.Divisibility and friends
#2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmckinna
changed the title
Algebra.Properties.Semiring.Divisibility and friends
JacquesCarette
approved these changes
Feb 10, 2025
Taneb
reviewed
Feb 10, 2025
|
Suggest: merging this as-is, but lifting out the |
JacquesCarette
approved these changes
Feb 13, 2025
MatthewDaggitt
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic (non-
breaking): : simplifiesimports and some proofs. Lifted out from #2573NB. Could go further (but then would be
breaking):NonTrivialto mean1# ≉ 0#(rather than0# ≉ 1#as used currently), and refactor to useNonTrivialas hypothesis (Blast! clashes withData.Nat.Base.NonTrivialwith a different semantics...)Relation.Binary.Construct.Interior.Symmetric, and exploit the generic properties of such relations