Skip to content

Make Friday compatible with agentscope v1.0.14#117

Merged
zhijianma merged 3 commits intoagentscope-ai:mainfrom
hongxicheng:bug2.3
Feb 4, 2026
Merged

Make Friday compatible with agentscope v1.0.14#117
zhijianma merged 3 commits intoagentscope-ai:mainfrom
hongxicheng:bug2.3

Conversation

@hongxicheng
Copy link
Collaborator

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with npm run format command in the root directory
  • Docstrings/comments are in appropriate style (TSDoc/JSDoc for TypeScript/JavaScript, Google style for Python)
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@hongxicheng hongxicheng requested a review from zhijianma February 3, 2026 07:45
@hongxicheng hongxicheng added the bug Something isn't working label Feb 3, 2026
@cla-assistant
Copy link

cla-assistant bot commented Feb 3, 2026

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist
Copy link

Summary of Changes

Hello @hongxicheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Friday application to ensure compatibility with agentscope v1.0.14. The primary changes involve upgrading the agentscope dependency to its full feature set and implementing a flexible approach to initialize JSONSession objects, accounting for potential variations in the session_id parameter across different agentscope versions.

Highlights

  • Dependency Update: The agentscope dependency in requirements.txt has been updated to agentscope[full], indicating a move to a more comprehensive installation of the library.
  • Conditional Session Initialization: The JSONSession constructor call in main.py now dynamically checks if session_id is an accepted parameter using Python's inspect module, adapting its instantiation based on the agentscope version to maintain compatibility.
Changelog
  • packages/app/friday/main.py
    • Added import inspect to facilitate runtime inspection of function signatures.
    • Modified the JSONSession instantiation logic to conditionally include the session_id argument based on whether the session_id parameter exists in the JSONSession constructor's signature.
  • packages/app/requirements.txt
    • Changed the agentscope dependency specification from agentscope to agentscope[full].
Activity
  • The pull request description includes a checklist for code formatting, documentation, and review readiness.
  • No specific human activity (comments, reviews, approvals) has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the application to be compatible with agentscope v1.0.14. The changes involve updating the requirements.txt and adding compatibility logic for JSONSession. My feedback focuses on improving the maintainability and consistency of the compatibility check by using an explicit version check, which is already a pattern in this codebase, instead of using the inspect module.

@zhijianma zhijianma self-requested a review February 4, 2026 02:49
@zhijianma zhijianma merged commit 584ed23 into agentscope-ai:main Feb 4, 2026
4 checks passed
@zhijianma zhijianma linked an issue Feb 4, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio Friday breaks with AgentScope v1.0.14 JSONSession API change

2 participants