-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beam] add DayDivider to list views #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…stview-day-divider
@crabinak I've added a commit that merges changes from the main branch, so you will have to pull before making more changes. |
…stview-day-divider
…r ISOString output vs. dateString output
@agritheory I updated this to use linkComponent. It accepts a Date object as the prop as well as an option to specify the format. As an example, I provided two date dividers: one as the default DateString and the other using ISOString. I didn't add more format types just incase this feature was not desired. I also left-aligned the DayeDivider content as having it center-aligned made it stand out but not in a good way. |
…stview-day-divider
07ade7b
to
2618f5a
Compare
9e5b233
to
39892cd
Compare
I added some minor processing changes, and here's what the latest iteration looks like: Let me know if that looks okay. |
@Alchez Looks good to me. @agritheory I updated this to use that light blue color you requested. I also removed the top border from the day divider as it was causing a double border with the bottom border from the previous item. |
@agritheory
I've added a DayDivider to the Beam ListView. I centered-aligned the text to help it visually stand out amongst the lists. The medium gray worked best here as the darker colors overpowered the navigation menu. This takes in month, day, and year as props and formats them to display, but it could be reworked to take in an object or however the date would be passed in.