-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beam] add MQTT stream composable #181
Conversation
The composable should ideally accept an array of topics to subscribe to and ignore all others. The topics would probably be managed as part of the application state (Pinia). If you want to subscribe to "all", use the "#" symbol, which is convention in MQTT. |
@agritheory I've added a fallback to subscribe to all topics via the broker, in case a list of topics isn't provided to the composable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this filing doing? I don't remember seeing a reviews folder before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an API report generated by the API Extractor plugin that I had added back in #136.
It basically lets you verify the public API of the package before it gets converted into documentation by the API Documenter plugin.
Ref: https://api-extractor.com/pages/overview/demo_api_report/
Closes #176
I tested the composable with an Artemis MQTT broker running locally (via https://github.com/agritheory/mqtt-pg-logger) and was able to see logging of published topic messages.
Screencast.From.2024-11-05.16-01-45.mp4
Notes:
mqtt
library but I'm not sure if we want to package our own implementation or use that one.