You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Pinia for data store, and also adds a new emit function inside ATable called cellUpdate that will trigger whenever the table data is updated, with the following signature:
@agritheory Let me know if this API looks good, and if it should expose anything else as well. Should we add a debounce to avoid spamming the emit handler?
Let me know if this API looks good, and if it should expose anything else as well. Should we add a debounce to avoid spamming the emit handler?
Will the debounce collect multiple changes and emit as a list or just wait for the changes to "settle"? I think the spammiest emit we would want to avoid is on the initial render
Will the debounce collect multiple changes and emit as a list or just wait for the changes to "settle"? I think the spammiest emit we would want to avoid is on the initial render
I think that'll depend on the implementation of the debounce (VueUse has a couple of debounced composables), but I think it would be most likely wait for the input to "settle".
We could also defer the debounce concern until it shows up in a real scenario, what do you think?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving towards completing https://github.com/agritheory/fab/issues/55.
Uses Pinia for data store, and also adds a new emit function inside
ATable
calledcellUpdate
that will trigger whenever the table data is updated, with the following signature: