Fix bugs in the Digest Header code where it did not meet the RFCs#375
Merged
RogerHardiman merged 1 commit intomasterfrom Nov 12, 2025
Merged
Fix bugs in the Digest Header code where it did not meet the RFCs#375RogerHardiman merged 1 commit intomasterfrom
RogerHardiman merged 1 commit intomasterfrom
Conversation
… a few makes of camera rejected this library. With these changes I've tested Digest Authentication (with WSSecurity disabled) with Axis, Avigilon, Bosch, ESP, Hanwha, HikVision, Panasonic and Sony cameras. 1) Code did not handle qop="auth,auth-int" due to comma in the middle of the string breaking split(). (Sony use auth,auth-int) 2) When QOP has multiple values, we have to pick one (we pick 'auth') 3) Not all key-value pairs in the Header need quotes. ESP and Panasonic failed wien NC and QOP used quotes in the reply due to strict checking in the camera.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few makes of camera rejected this library as it did not correctly implement the RFCs for Digest.
With these changes I've tested Digest Authentication (with WSSecurity disabled) with Axis, Avigilon, Bosch, ESP, Hanwha, HikVision, Panasonic and Sony cameras.