Skip to content

Bug/discovery full udp buffer#378

Merged
RogerHardiman merged 3 commits intoagsh:masterfrom
momoAmch:bug/discovery_full_udpBuffer
Nov 13, 2025
Merged

Bug/discovery full udp buffer#378
RogerHardiman merged 3 commits intoagsh:masterfrom
momoAmch:bug/discovery_full_udpBuffer

Conversation

@momoAmch
Copy link
Contributor

lease refer to this issue for further information #377

Add an option to configure the UDP receive buffer size as an option on probe function
Use setImmediate inside the 'message' listener to defer heavy parsing to the next event loop phase.

use setImediate to avoid udp packets lost
improve binding and send probe message on binding
@RogerHardiman
Copy link
Collaborator

Many thanks for the changes.
Testing it now.

Thanks for the useAddr addition.
And thank you for spotting what looks like a race condition where the Discovery message is not waiting for Bind() to complete.
I like the SetImmediate() to move the XML processing off the main event loop.

My only comment was the option to increase the buffer size.
Perhaps we should always increase the buffer size.

@RogerHardiman RogerHardiman merged commit 7fcf23d into agsh:master Nov 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants