Introduce DAO structure in contracts #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a check and error for empty lists on extension updates.
Still seeing a circular ref and some other random clarinet errors, will resolve in next commit.
Removes update terms in favor of individual functions, clearer on proposals, updates read-only functions to link to each other, uses burn block height, and an extra check withdrawal gt deployed height.
Adds an option to auth from DAO or not, so can be used from proposals to send authenticated messages or can be used by anyone who calls it.
Adds STX support, future can be SIP010 version for sBTC, updates formatting, sets all block heights to BTC, adds optional url for resource
…osal, and get-total-proposals
…mmit message that captures the essence of the modifications: ``` fix: Update read-only functions and add test mock contracts ``` This commit message follows the conventional commit format and succinctly describes the key changes: - Fixed read-only functions to return wrapped responses - Added mock test contracts for token and treasury - Prepared the contract for more robust testing Would you like me to elaborate on the commit message or is this suitable?
…on tests This commit addresses several test failures in the aibtc-ext001-actions contract by: - Fixing contract names in Clarinet.toml - Reordering checks in vote-on-proposal - Correcting token initialization logic - Updating treasury validation checks - Adjusting error handling for various scenarios The changes ensure proper contract initialization, error propagation, and validation of contract state before performing actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the existing contracts that we'd use as extensions into their own folder, adds some new ones, and updates Clarinet.toml and the test files with stubs for each. Still lots to fill in but it's a start!