Feature/viewer layout#747
Draft
cpignedoli wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/viewercontrols #747 +/- ##
==========================================================
+ Coverage 85.12% 85.23% +0.10%
==========================================================
Files 18 18
Lines 3421 3514 +93
==========================================================
+ Hits 2912 2995 +83
- Misses 509 519 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I will fix pan functionality after merging of #742 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #745 and focuses on improving the usability/layout of the structure viewer controls.
Depends on #745.
Changes
StructureManagerWidgetuse a full-width structure viewer by default, with the detailed viewer controls collapsed below the geometry.Below/Sidecontrols layout switch in the Appearance tab.Show view helptext.Validation
python -m ruff format aiidalab_widgets_base/viewers.py aiidalab_widgets_base/structures.py tests/test_viewers.pypython -m ruff check aiidalab_widgets_base/viewers.py aiidalab_widgets_base/structures.py tests/test_viewers.pypython -m compileall aiidalab_widgets_base/viewers.py aiidalab_widgets_base/structures.py tests/test_viewers.pyBelow/SideswitchingFull
pytestcould not be run locally because the existing AiiDA/pgtest setup tries to call the missinglocateexecutable while searching forpg_ctlbefore the test body starts.Screen.Recording.2026-05-19.at.10.44.11.mov