Skip to content

🐛 Derive broker entry point from class - #7475

Draft
agoscinski wants to merge 1 commit into
aiidateam:mainfrom
agoscinski:feat/dynamic-entry-point
Draft

🐛 Derive broker entry point from class#7475
agoscinski wants to merge 1 commit into
aiidateam:mainfrom
agoscinski:feat/dynamic-entry-point

Conversation

@agoscinski

Copy link
Copy Markdown
Collaborator

Add a generic Broker.ENTRY_POINT classproperty that resolves the registered broker entry point from the concrete class.

Use this in ZeromqBroker when validating the configured backend, removing the hardcoded core.zeromq string and adding coverage for the derived entry point.

TODO: extend the same pattern to other plugin base classes where code currently hardcodes entry point names.

Add a generic `Broker.ENTRY_POINT` classproperty that resolves the
registered broker entry point from the concrete class.

Use this in `ZeromqBroker` when validating the configured backend,
removing the hardcoded `core.zeromq` string and adding coverage for the
derived entry point.

TODO: extend the same pattern to other plugin base classes where code
currently hardcodes entry point names.
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 35bcc22b-2a8d-4194-81ab-a60326075a87

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.30%. Comparing base (88ccac9) to head (702b930).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/brokers/broker.py 40.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (88ccac9) and HEAD (702b930). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (88ccac9) HEAD (702b930)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7475       +/-   ##
===========================================
- Coverage   80.62%   30.30%   -50.31%     
===========================================
  Files         581      581               
  Lines       46806    46810        +4     
===========================================
- Hits        37731    14183    -23548     
- Misses       9075    32627    +23552     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant