🐛 Derive broker entry point from class - #7475
Conversation
Add a generic `Broker.ENTRY_POINT` classproperty that resolves the registered broker entry point from the concrete class. Use this in `ZeromqBroker` when validating the configured backend, removing the hardcoded `core.zeromq` string and adding coverage for the derived entry point. TODO: extend the same pattern to other plugin base classes where code currently hardcodes entry point names.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7475 +/- ##
===========================================
- Coverage 80.62% 30.30% -50.31%
===========================================
Files 581 581
Lines 46806 46810 +4
===========================================
- Hits 37731 14183 -23548
- Misses 9075 32627 +23552 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add a generic
Broker.ENTRY_POINTclassproperty that resolves the registered broker entry point from the concrete class.Use this in
ZeromqBrokerwhen validating the configured backend, removing the hardcodedcore.zeromqstring and adding coverage for the derived entry point.TODO: extend the same pattern to other plugin base classes where code currently hardcodes entry point names.