Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.3.0 #77

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Release/2.3.0 #77

merged 1 commit into from
Nov 21, 2024

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented May 8, 2024

No description provided.

@mbercx mbercx requested a review from sphuber May 8, 2024 17:00
@mbercx mbercx requested review from t-reents and Minotakm July 29, 2024 11:42
t-reents
t-reents previously approved these changes Jul 30, 2024
Copy link
Collaborator

@t-reents t-reents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is a kind of standard function (also used in AiiDA-QE) that requires some manual adjustments, anyway. However, I realized that the title Changelog is simply overwritten and that the date is missing next to the new version. Therefore, I added some small suggestions to also respect these aspects in the generated template.

@mbercx
Copy link
Member Author

mbercx commented Nov 21, 2024

Thanks @t-reents! I simply removed the title in 11f7a92, that simplifies the code and I don't see a reason to keep it. ^^

Going to merge once the tests pass. 🚀

@mbercx mbercx merged commit 6a2598b into main Nov 21, 2024
10 checks passed
@mbercx mbercx deleted the release/2.3.0 branch November 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants