Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ENH: add support for all types of problems in Bidirectional Search #1147

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

tirthasheshpatel
Copy link
Contributor

Fixes #1144

I have added support for all types of problems in Bidirectional Search and their tests.

I am still confused about two things:

  1. How to return the node containing the solution path along with the U value in BS? Maybe, we can also add that like all other search algorithms.
  2. We need to traverse through each node to calculate the e (minimum edge value) value which can take exponential time for large problems. So, is it fine to initialize it to 0 or there is a way to calculate it?

@antmarakis
Copy link
Collaborator

  1. Implementing this functionality like in the rest of the algorithms sounds like the way to go, definitely!

  2. I think if we initialize them at 0 it would be fine. Maybe add a TODO comment next to the initialization to let people know maybe a better initialization can be explored.

@antmarakis antmarakis merged commit 69b6a46 into aimacode:master Jan 8, 2020
@tirthasheshpatel tirthasheshpatel deleted the patch/bs branch January 8, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for all types of problems in Bidirectional Search
2 participants