Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos in gui folder #1150

Merged
merged 204 commits into from
Jan 25, 2020
Merged

fixed typos in gui folder #1150

merged 204 commits into from
Jan 25, 2020

Conversation

dmeoli
Copy link
Contributor

@dmeoli dmeoli commented Jan 8, 2020

No description provided.

dmeoli added 30 commits March 24, 2019 17:03
Changed queue to set in AC3 (as in the pseudocode of the original algorithm) to reduce the number of consistency-check due to the redundancy of the same arcs in queue. For example, on the harder1 configuration of the Sudoku CSP the number consistency-check has been reduced from 40464 to 12562!
AC3 algorithm has non-optimal worst case time-complexity O(cd^3 ), while AC4 algorithm runs in O(cd^2) worst case time
…he constant propagation algorithm in mac inference
… are already present in test_csp.py"

This reverts commit b3cd24c.
…oosing the constant propagation algorithm in mac inference"

This reverts commit 6986247.
This reverts commit 6641c2c.
@omar-3
Copy link
Contributor

omar-3 commented Jan 8, 2020

same issue as with pr #1148

@antmarakis
Copy link
Collaborator

I would like to know, what are you planning on doing with the DL functions you removed? Are you going to add them to learning, or something else? I think they should be put in the DL script.

@dmeoli
Copy link
Contributor Author

dmeoli commented Jan 24, 2020

I would like to know, what are you planning on doing with the DL functions you removed? Are you going to add them to learning, or something else? I think they should be put in the DL script.

I removed the classes that use Keras because I think that the repository's focus is to propose simple and intuitive implementations to the problems proposed in the book and not to wrap other high-level DL libraries.
I hope someone wants to try in the future with the implementation of these classes, maybe I will try in a short future in the context of the Computational Neuroscience exam.

@antmarakis
Copy link
Collaborator

Thing is, I was not the one who merged these commits, so I am not sure what to do with them. I remember a while ago Dr. Norvig wanted to start using TensorFlow in here, so maybe this is it.

I would prefer if they remained in there, just to be safe.

@dmeoli
Copy link
Contributor Author

dmeoli commented Jan 24, 2020

Thing is, I was not the one who merged these commits, so I am not sure what to do with them. I remember a while ago Dr. Norvig wanted to start using TensorFlow in here, so maybe this is it.

I would prefer if they remained in there, just to be safe.

Ok @antmarakis, in the meanwhile I provided to re-added Keras class in order to give you the possibility to merge the others changes.

@antmarakis antmarakis merged commit 1b24e0d into aimacode:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants