added LinearRegressionLearner, LogisticRegressionLearner with tests and fixed NeuralNetLearner and PerceptronLearner #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed queue to set in AC3 (as in the pseudocode of the original algorithm) to reduce the number of consistency-check due to the redundancy of the same arcs in queue. For example, on the harder1 configuration of the Sudoku CSP the number consistency-check has been reduced from 40464 to 12562!
AC3 algorithm has non-optimal worst case time-complexity O(cd^3 ), while AC4 algorithm runs in O(cd^2) worst case time
…he constant propagation algorithm in mac inference
…eady present in test_csp.py
This reverts commit 20ab0e5.
This reverts commit f743146.
This reverts commit 9e0fa55.
… are already present in test_csp.py" This reverts commit b3cd24c.
…oosing the constant propagation algorithm in mac inference" This reverts commit 6986247.
This reverts commit 03551fb.
This reverts commit 93af259.
This reverts commit 6641c2c.
This reverts commit 9d37ae0.
antmarakis
reviewed
Jan 29, 2020
There was a problem hiding this comment.
In general, even though this is impressive work, it makes some pretty big changes that I cannot authorize. The creation of the Learner class isn't entirely necessary and I am not sure this is where @norvig wants to take this. I think as functions the algorithms here work just as well for the purposes of this.
As always, small PRs are way more welcome than longer ones. We need incremental changes, nothing as sweeping as this I'm afraid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.