BugFix in aiohttp.ClientSession that caused "Unclosed connector" warnings #11696
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #11696 will improve performances by 12.65%Comparing Summary
Benchmarks breakdown
Footnotes |
Ruke3663
changed the title
for more information, see https://pre-commit.ci
| ) | ||
|
|
||
| if connector is None: | ||
| connector_owner = True |
There was a problem hiding this comment.
I feel like this is the only line that is potentially related to the title of this PR? Though surely only fixing an issue where someone incorrectly passes connector_owner=False without a connector (in which case we should probably error on the incorrect arguments, rather than just override it).
|
We'll need a regression test that reproduces the reported issue too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes fix a bug in
aiohttp.ClientSessionthat caused "Unclosed connector" warnings when a user-provided connector was used.The session now correctly distinguishes between internally created and externally provided connectors, ensuring it only closes connectors that it owns.
Are there changes in behavior for the user?
Yes, there is a positive change in behavior.
Users who provide their own
TCPConnectorinstance to aClientSessionwill no longer seeResourceWarning: Unclosed connectorwarnings when the session is closed.The lifecycle of the external connector remains entirely under the user’s control, as expected.
The behavior for internally created connectors is unchanged.
Is it a substantial burden for the maintainers to support this?
No, this change should not be a burden to maintain.
It corrects the logic to align with the library’s intended design and documentation.
The fix is:
ClientSession’s__init__andclosemethods.This should be easy to support long-term.
Related issue number
"2e6: With explicit connector reuse, aiohttp.ClientSession fails to close connector when using async context"