-
-
Notifications
You must be signed in to change notification settings - Fork 42
fix: restore pickling of FrozenList in the C extension #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mukller
wants to merge
6
commits into
aio-libs:master
Choose a base branch
from
Mukller:fix/cext-pickling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16,249
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
08572bf
fix: restore pickling of FrozenList in the C extension (#834)
Mukller 719ea21
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5388df2
fix: preserve subclass in unpickling; add subclass round-trip test
Mukller 21540fd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b956d6d
fix(tests): silence mypy on the intentional alias-dispatch pattern
Mukller f7fa46a
style(pyx): satisfy cython-lint blank-line rules around _unpickle_fro…
Mukller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| Fixed pickling of ``FrozenList`` instances when the C extension is used -- by :user:`Mukller`. | ||
|
|
||
| The free-threading change that stored the frozen flag in a C++ ``atomic[bint]`` | ||
| made Cython's default reducer fail with ``TypeError: self._frozen cannot be | ||
| converted to a Python object for pickling``. An explicit ``__reduce__`` now | ||
| serializes ``(items, frozen)`` explicitly, restoring parity with the | ||
| pure-Python implementation. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.