PoC: Add plan modifier to selected_fields #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a stream in a connection has field paths defined whose ordering does not match exactly with the way it's retrieved from the API, it is reported as a "change" regardless of whether there were any actual changes.
This is a proof of concept to add a plan modifier on the selected_fields that sorts the field paths in the plan by length, smallest first. This is the ordering the plan seems to be getting compared against. From my local testing it appears to work to silence the spurious changes in the fields.
As a disclaimer: I don't develop providers and I'm aware that Speakeasy is the one that generates this provider, so I'm not expecting this to get merged.