Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing logging statements in some scripts #2917

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Jan 18, 2024

WHAT DOES THIS PR DO?

  • Reducing logging statements in some scripts

HOW DO I TEST OUT THIS PR?

cd /src/device-registry
npm install
npm run dev-mac

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f26a8ed) 30.92% compared to head (7d405c4) 30.93%.
Report is 10 commits behind head on staging.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2917      +/-   ##
===========================================
+ Coverage    30.92%   30.93%   +0.01%     
===========================================
  Files          184      184              
  Lines        23853    23844       -9     
  Branches      3061     3061              
===========================================
  Hits          7377     7377              
+ Misses       16359    16350       -9     
  Partials       117      117              
Files Coverage Δ
src/device-registry/bin/store-readings-job.js 27.08% <ø> (+0.55%) ⬆️
src/device-registry/bin/kafka-consumer.js 35.59% <0.00%> (+4.24%) ⬆️

Copy link
Contributor

Device registry changes in this PR available for preview here

@Baalmart Baalmart merged commit db7af70 into staging Jan 18, 2024
47 of 48 checks passed
@Baalmart Baalmart deleted the reducing-comments branch January 18, 2024 14:38
@Baalmart Baalmart mentioned this pull request Jan 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant